Skip to content
This repository has been archived by the owner on Jan 9, 2023. It is now read-only.

Feature/datetime factory improvement #492

Closed

Conversation

BazinC
Copy link

@BazinC BazinC commented Jun 16, 2020

No breaking changes
-Added the missing dateTimeFactory parameter on TimeSeriesChart.createCommonChart method.
It also fixes #490

-Added a Timezone aware DateTimeFactory implementation (related to a TODO left for @cbbraun)
I use this implementation in a prod application with localized Data visualisation, this feature is needed and useful.

@lorrainekan , as you seem to be the most active maintainer on this repo on this repo, could you please take a look ? :) Thanks a lot 🙏

Corentin

@winksaville
Copy link

There is a fork of charts at exafree/charts_cf that accepts pull requests.

@BazinC
Copy link
Author

BazinC commented Jun 21, 2020

There is a fork of charts at exafree/charts_cf that accepts pull requests.

Thanks for the information ! Great idea :D

@winksaville
Copy link

Thanks for the information ! Great idea :D

@BazinC, please create a PR there.

@stuartmorgan
Copy link
Collaborator

This project is no longer maintained, and cannot accept any PRs. Community members interested in collaborating on a community-maintained fork can coordinate in this issue.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support timezone localization in TimeSeriesChart [Feature Request]
4 participants