Skip to content
This repository has been archived by the owner on Jan 9, 2023. It is now read-only.

with compile works for flutter3.0 #768

Closed
wants to merge 13 commits into from
Closed

Conversation

joyhope
Copy link

@joyhope joyhope commented May 17, 2022

only version update for easy to run the sample in the simulator. Otherwise the original project is unable to run now.

@google-cla
Copy link

google-cla bot commented May 17, 2022

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

For more information, open the CLA check for this pull request.

@joyhope
Copy link
Author

joyhope commented May 20, 2022

The fixed type will make sample "selection line highlight custom shape works"

… so sample selection Line Highight Cusom Shape works
@joyhope
Copy link
Author

joyhope commented May 20, 2022

I recommit, the sample case is working now.

@joyhope
Copy link
Author

joyhope commented May 20, 2022

More unworkable samples are worked. It all caused a type cast problem. I changed the type define according to the error report. It just works.

@crizant
Copy link

crizant commented May 20, 2022

Seems Google is giving up this repo, every time a new flutter version comes out, this repo lags behind for months.
Do you think we should fork it and publish another version to pub.dev?
No new features, just simple fixes of incompatibility with the latest flutter versions. It should relieve the pain of fellow developers.

@joyhope
Copy link
Author

joyhope commented May 21, 2022

I agree with this idea, but I am not sure whether it is proper. I begin to add features but it seems no hope to merge in this repo. If anyone makes a start, I like to follow. I think the chart is an important library to use.

@joyhope
Copy link
Author

joyhope commented May 21, 2022

I add chart_flutter/util/monotonex.dart , add smoth line to the chart.
Screenshot from 2022-05-20 22-28-20

the chart line is smooth. but I am not sure whether this will be merged.

@crizant
Copy link

crizant commented May 21, 2022

I add chart_flutter/util/monotonex.dart , add smoth line to the chart. Screenshot from 2022-05-20 22-28-20

the chart line is smooth. but I am not sure whether this will be merged.

Even if it got merged finally, it will be 2 months later.
E.g. Flutter 2.2 null safety is released in May 2021, and the null safety fix of this library is released in July 2021.

@stuartmorgan
Copy link
Collaborator

This project is no longer maintained, and cannot accept any PRs. Community members interested in collaborating on a community-maintained fork can coordinate in this issue.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants