Skip to content
This repository has been archived by the owner on Jun 4, 2021. It is now read-only.

Expand Retry Logic #105

Open
jpoehnelt opened this issue Sep 4, 2018 · 2 comments
Open

Expand Retry Logic #105

jpoehnelt opened this issue Sep 4, 2018 · 2 comments

Comments

@jpoehnelt
Copy link
Member

It would be nice if the pusher retried on 504s and other similar responses that occur when backends are having issues. For example, today: https://status.cloud.google.com/incident/cloud-dev-tools/18003#18003003

@drigz
Copy link
Member

drigz commented Jan 31, 2019

+1, I ran into this when pushing multiple images in parallel to a newly created projects (with rules_docker's container_push). The first request succeeds, but the next 10 or so fail with a 503.

@fahhem
Copy link

fahhem commented Jun 18, 2020

We've (not Google) done this by overriding/extending the ShouldRetry function in the RetryTransport class, which was nicely setup to allow that. Is that useful?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants