Skip to content
This repository has been archived by the owner on Dec 3, 2024. It is now read-only.

NewSink constructor should accept an interface #20

Open
tam7t opened this issue Sep 1, 2021 · 0 comments
Open

NewSink constructor should accept an interface #20

tam7t opened this issue Sep 1, 2021 · 0 comments

Comments

@tam7t
Copy link
Contributor

tam7t commented Sep 1, 2021

https://pkg.go.dev/github.com/google/go-metrics-stackdriver#NewSink

currently only accepts a https://pkg.go.dev/cloud.google.com/go/monitoring/apiv3#MetricClient

which says:

Deprecated: Please use cloud.google.com/go/monitoring/apiv3/v2.

This was also mentioned #16 but would be a breaking change to the package.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant