Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Inconsistent hint text on offline map imagery list #2118

Closed
gino-m opened this issue Dec 13, 2023 · 5 comments · Fixed by #2680
Closed

Inconsistent hint text on offline map imagery list #2118

gino-m opened this issue Dec 13, 2023 · 5 comments · Fixed by #2680
Labels
good first issue type: bug Something isn't working
Milestone
GA release

Comments

@gino-m
Copy link
Collaborator

gino-m commented Dec 13, 2023

When no imagery downloaded, text says to tap "Select and download", but the fab label is "Select area".
@github-project-automation github-project-automation bot moved this to Todo in Ground Dec 13, 2023
@gino-m gino-m added this to Ground Dec 18, 2023
@gino-m gino-m modified the milestones: EUDR MVP, EUDR Launch Dec 19, 2023
@shobhitagarwal1612
Copy link
Member

shobhitagarwal1612 commented Jul 20, 2024 •
edited
Loading

@gino-m What should be FAB label when there is no offline imagery?

@gino-m
Copy link
Collaborator Author

gino-m commented Jul 20, 2024 •
edited
Loading

@gino-m What should be FAB label when there are no offline imagery?

Can you paste screenshots for input for @amegantz ?

@shobhitagarwal1612
Copy link
Member

Screenshot_20240720_210721

@gino-m
Copy link
Collaborator Author

gino-m commented Jul 29, 2024

@shobhitagarwal1612 Thanks! The designs have something a little different, but I suspect the text there should say "No map imagery downloaded for offline use":

image

@amegantz Can you confirm?

@amegantz
Copy link

image
Works for me!

@gino-m gino-m removed their assignment Aug 5, 2024
@anandwana001 anandwana001 mentioned this issue Aug 22, 2024
Merged
@github-project-automation github-project-automation bot moved this to Done in Ground Aug 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue type: bug Something isn't working
Projects
Ground
Status: Done
Ground
Status: Todo
Milestone
GA release
Development

Successfully merging a pull request may close this issue.

hint text on offline map imagery list anandwana001/ground-android
3 participants
@gino-m @shobhitagarwal1612 @amegantz