Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Code health] MutationRepository Cleanup #2119

Closed
scolsen opened this issue Dec 14, 2023 · 1 comment
Closed

[Code health] MutationRepository Cleanup #2119

scolsen opened this issue Dec 14, 2023 · 1 comment
Labels
type: code health Improvements to readability or robustness of codebase
Milestone

Comments

@scolsen
Copy link
Contributor

scolsen commented Dec 14, 2023

I think our overall approach and design will be simplified if we dumb down the logic the MutationRepository offers and offload some processing into methods defined directly on our mutation value types.

@scolsen scolsen added type: code health Improvements to readability or robustness of codebase priority: p2 labels Dec 14, 2023
@github-project-automation github-project-automation bot moved this to Todo in Ground Dec 14, 2023
@gino-m gino-m added this to Ground Dec 19, 2023
@gino-m gino-m added this to the EUDR Launch milestone Dec 19, 2023
@gino-m
Copy link
Collaborator

gino-m commented Nov 26, 2024

Working on #2867 now; exposing more fine-grained logic from MutationRepository has a few benefits:

  • It makes the workers more readable, since a named handle for these methods are available rather than needing to depend on the details of how states are represented internally.
  • It makes code less fragile by keeping the moving the "how" states are represented closer to the data rather than the business logic.

Closing for now, @scolsen please reopen if you have strong feelings about this!

@gino-m gino-m closed this as not planned Won't fix, can't repro, duplicate, stale Nov 26, 2024
@github-project-automation github-project-automation bot moved this to Done in Ground Nov 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: code health Improvements to readability or robustness of codebase
Projects
Status: Done
Status: Todo
Development

No branches or pull requests

2 participants