-
Notifications
You must be signed in to change notification settings - Fork 120
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Non-unique IDs for tasks in different jobs cause tasks to be overwritten in local DB #2484
Comments
Note from Gino: we should work toward using protos in the local db as well. It would be more valuable to fix this temporarily via destructive changes and to work toward leveraging protos instead. |
I propose the following solution long-term:
|
@scolsen Using protos everywhere is a much larger project. A patch is low priority here since this is a degenerate case which would only happen if someone accidentally manually adds to jobs with the same IDs. Moving to Icebox. |
Unassigning @scolsen and removing from the current iteration, based on latest comments |
@scolsen @anandwana001 Can you confirm that tasks with the same ID in different jobs will no longer break the local db? |
Simple solution: use both survey and job UUID when syncing in local db. |
Demoting to P2 since this won't happen unless we add a duplicate job ID by hand server side. |
This leads to various odd behaviors, like jobs not showing up as "free form" data collection, or jobs having no tasks.
Instead, we should avoid using UUID as PKs in the local db. Instead, we can generate unique numeric IDs, or prevent non-unique IDs in the local DB.
This problem will go away if we serialize the survey as a binary proto in the local db.
The text was updated successfully, but these errors were encountered: