Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Read and load Surveys, Jobs, and Tasks from proto #2553

Merged
merged 24 commits into from
Jul 24, 2024

Conversation

sufyanAbbasi
Copy link
Contributor

@sufyanAbbasi sufyanAbbasi commented Jul 18, 2024

Towards #1730
Fixes #2500
Fixes #2501

Reads Surveys and Jobs from proto, with back support for older databases that don't use proto.

  • Ran a local ground-platform at HEAD via npm run start:local
  • Created a survey with all question types
  • Ran the emulator in localDebug variant which pull from local emulator
  • Ensured that old, non-proto surveys still load as a fallback.

PTAL @gino-m, @shobhitagarwal1612!

Sorry, something went wrong.

sufyanAbbasi and others added 15 commits July 15, 2024 15:35

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
gino-m
gino-m previously requested changes Jul 19, 2024
Copy link
Collaborator

@gino-m gino-m left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazing! 💯 A few nits, excited to merge this one!

@sufyanAbbasi
Copy link
Contributor Author

/gcbrun

sufyanAbbasi and others added 2 commits July 23, 2024 19:58
# Conflicts:
#	ground/build.gradle

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
@sufyanAbbasi sufyanAbbasi removed the request for review from gino-m July 24, 2024 18:59
@sufyanAbbasi sufyanAbbasi dismissed gino-m’s stale review July 24, 2024 19:00

Addressed comments, currently OOO

@sufyanAbbasi sufyanAbbasi merged commit 49ca1e7 into master Jul 24, 2024
2 checks passed
@sufyanAbbasi sufyanAbbasi deleted the sufy/2467/protobuf branch July 24, 2024 19:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use protos when reading survey Use protos when reading survey list
3 participants