-
Notifications
You must be signed in to change notification settings - Fork 121
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Read and load Surveys, Jobs, and Tasks from proto #2553
Merged
Merged
+643
−104
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gino-m
previously requested changes
Jul 19, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Amazing! 💯 A few nits, excited to merge this one!
.../java/com/google/android/ground/persistence/remote/firebase/schema/ConditionConverterTest.kt
Outdated
Show resolved
Hide resolved
...c/test/java/com/google/android/ground/persistence/remote/firebase/schema/JobConverterTest.kt
Outdated
Show resolved
Hide resolved
shobhitagarwal1612
requested changes
Jul 20, 2024
...rc/main/java/com/google/android/ground/persistence/remote/firebase/schema/SurveyConverter.kt
Outdated
Show resolved
Hide resolved
/gcbrun |
# Conflicts: # ground/build.gradle
shobhitagarwal1612
approved these changes
Jul 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Towards #1730
Fixes #2500
Fixes #2501
Reads Surveys and Jobs from proto, with back support for older databases that don't use proto.
survey/<SURVEY_ID>/jobs
for the jobs belonging to the survey.*Converters
andFirestoreToProtobufExt
ground-platform
at HEAD vianpm run start:local
localDebug
variant which pull from local emulatorPTAL @gino-m, @shobhitagarwal1612!