-
Notifications
You must be signed in to change notification settings - Fork 120
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Draw area] Don't allow user to draw mis-shapen polygons #2604
Comments
After rejecting the vertex, maybe we show a toast/snackbar and say something like:
WDYT? |
I vote for 3, possibly removing the term "area", which we no longer mention during the data collection flow, so:
|
Works for me |
Thanks, @rawbzz. Both options look good, I'm leaning towards the second option since it provides an explicit way of dismissing the message which isn't close to the "Add point" tap target, helping to mitigate accidental taps. Assuming the 2nd option, I would update the label - the current label sounds like tapping might add a point. Perhaps a simple "Ok" would be better (@amegantz) |
agreed i like the second option |
Thanks @rawbzz , updated the PR description accordingly. |
Do not allow self-intersecting polygons to be added.
When trying to add a vertex that would introduce an invalid polygon, we'll show a dialog with the message ""Areas can't intersect with themselves" and "Ok" button to dismiss.
The text was updated successfully, but these errors were encountered: