Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Capture location] Prompt for location permissions when capture location task is opened #2658

Closed
shobhitagarwal1612 opened this issue Aug 16, 2024 · 17 comments · Fixed by #2818
Assignees
Labels
type: fr Request for new feature
Milestone

Comments

@shobhitagarwal1612
Copy link
Member

No description provided.

@gino-m gino-m changed the title Prompt for location permissions when the app is opened [Capture location] Prompt for location permissions when the capture location is opened Aug 16, 2024
@gino-m gino-m added the type: fr Request for new feature label Aug 16, 2024
@gino-m gino-m added this to the GA release milestone Aug 16, 2024
@gino-m gino-m changed the title [Capture location] Prompt for location permissions when the capture location is opened [Capture location] Prompt for location permissions when capture location task is opened Aug 16, 2024
@gino-m
Copy link
Collaborator

gino-m commented Aug 21, 2024

Capture location task may be replaced with "drop pin" task; we should get clarity on that before implementing this.

@gino-m
Copy link
Collaborator

gino-m commented Aug 22, 2024

As per @jo-spek we still need both capture location and drop pin as distinct tasks.

@anandwana001
Copy link
Collaborator

@gino-m For Capture Location. Task, we have a location lock, so the permission dialog will always appear on the screen.

Do we need the same for Drop Pin & Draw or walk permiter?

@gino-m
Copy link
Collaborator

gino-m commented Aug 27, 2024

The permissions should only be requested when needed: on "Drop pin" and "Walk perimeter" screens when the user taps the location lock, and immediately on the "Capture location" screen.

@anandwana001
Copy link
Collaborator

ah, got it.

The current scenerio is,the permission dialog comes up at the first time, but if the user reject it, the location lock button is getting disabled by default and click is not working on it.

Let me check and raise a pr for this fix.

@anandwana001
Copy link
Collaborator

@gino-m if you could confirm the below user journey

Do we need to show the location permission if user moves back and forth? First time it is working fine.

Screen.Recording.2024-08-27.at.10.52.45.PM.mov

@gino-m
Copy link
Collaborator

gino-m commented Aug 27, 2024

For "capture location" tasks I would say yes. Rather than showing "Map location" on those tasks when location is disabled perhaps we want to say "Allow location sharing to continue?"

@anandwana001
Copy link
Collaborator

@gino-m ok,

So, earlier we had kept the location button locked in the Capture Task, but now we have to keep to open so that user can click and get the permission dialog box, but if user disabled it keeping the device location enabled, we will not move forward.

Let me raise a PR for better understanding with user journey video

@gino-m
Copy link
Collaborator

gino-m commented Aug 29, 2024

@kenstershiro The question here is how to handle the case when the user refuses access to location during the "capture location" data collection tasks. The first solution that comes to would be to show a modal dialog that doesn't let the user proceed until location permission is granted. To dialog could have two buttons, something like "Try again" or "Discard changes". The former would re-request permissions, the latter would close the data collection flow. Wdyt?

@gino-m gino-m added the ux needed Product input from PM/UX needed label Aug 29, 2024
@anandwana001
Copy link
Collaborator

@kenstershiro gentle reminder

@gino-m
Copy link
Collaborator

gino-m commented Sep 25, 2024

@anandwana001 For now let's assume the user is directed to the dialog in #2635. If they say "no, don't leave survey", they'll be prompted for location permission again.

@amegantz Should we show custom text here to the dialog in this case do the tune of "If you don't grant location permission you can't continue to collect data for this site...." Buttons: "Exit" | "Try again"?

@anandwana001
Copy link
Collaborator

Screen.Recording.2024-10-08.at.1.46.08.PM.mov

@gino-m
Copy link
Collaborator

gino-m commented Oct 9, 2024

@amegantz Should we show custom text here to the dialog in this case do the tune of "If you don't grant location permission you can't continue to collect data for this site...." Buttons: "Exit" | "Try again"?

@amegantz Gentle ping

@amegantz
Copy link

amegantz commented Oct 9, 2024

Sorry for the late response. How about this? Tried to connect it to the "Allow location" Android screen as much as possible.

Allow location sharing
If you don't allow Ground to access this device’s location, you won’t be able to continue collecting data for this site.
[Exit] [Allow location]

Image

@gino-m gino-m removed the ux needed Product input from PM/UX needed label Oct 9, 2024
@gino-m
Copy link
Collaborator

gino-m commented Oct 9, 2024

Back to you @anandwana001 !

@gino-m
Copy link
Collaborator

gino-m commented Nov 4, 2024

@anandwana001 we spoke @kenstershiro my suggestions to consider case of "optional" capture location tasks:

  • Show dialog when opening capture location task if permissions not already granted. Updated buttons to say "Cancel" or "Allow location"
  • If the user says "Cancel", return to task but disable "Capture" button.
  • Fix location lock button so that the user can tap it to re-request location permission.
  • If the task is required but they don't allow location their only option will be do exit by clicking the "x" in the top-left corner.

@kenstershiro
Copy link
Collaborator

@gino-m @anandwana001 sounds good to me

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: fr Request for new feature
Projects
Status: Done
5 participants