-
Notifications
You must be signed in to change notification settings - Fork 120
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Capture location] Prompt for location permissions when capture location task is opened #2658
Comments
Capture location task may be replaced with "drop pin" task; we should get clarity on that before implementing this. |
As per @jo-spek we still need both capture location and drop pin as distinct tasks. |
@gino-m For Capture Location. Task, we have a location lock, so the permission dialog will always appear on the screen. Do we need the same for Drop Pin & Draw or walk permiter? |
The permissions should only be requested when needed: on "Drop pin" and "Walk perimeter" screens when the user taps the location lock, and immediately on the "Capture location" screen. |
ah, got it. The current scenerio is,the permission dialog comes up at the first time, but if the user reject it, the location lock button is getting disabled by default and click is not working on it. Let me check and raise a pr for this fix. |
@gino-m if you could confirm the below user journey Do we need to show the location permission if user moves back and forth? First time it is working fine. Screen.Recording.2024-08-27.at.10.52.45.PM.mov |
For "capture location" tasks I would say yes. Rather than showing "Map location" on those tasks when location is disabled perhaps we want to say "Allow location sharing to continue?" |
@gino-m ok, So, earlier we had kept the location button locked in the Capture Task, but now we have to keep to open so that user can click and get the permission dialog box, but if user disabled it keeping the device location enabled, we will not move forward. Let me raise a PR for better understanding with user journey video |
@kenstershiro The question here is how to handle the case when the user refuses access to location during the "capture location" data collection tasks. The first solution that comes to would be to show a modal dialog that doesn't let the user proceed until location permission is granted. To dialog could have two buttons, something like "Try again" or "Discard changes". The former would re-request permissions, the latter would close the data collection flow. Wdyt? |
@kenstershiro gentle reminder |
@anandwana001 For now let's assume the user is directed to the dialog in #2635. If they say "no, don't leave survey", they'll be prompted for location permission again. @amegantz Should we show custom text here to the dialog in this case do the tune of "If you don't grant location permission you can't continue to collect data for this site...." Buttons: "Exit" | "Try again"? |
Screen.Recording.2024-10-08.at.1.46.08.PM.mov |
Back to you @anandwana001 ! |
@anandwana001 we spoke @kenstershiro my suggestions to consider case of "optional" capture location tasks:
|
@gino-m @anandwana001 sounds good to me |
No description provided.
The text was updated successfully, but these errors were encountered: