Duplicate Tasks or Tasks are getting Skipped

[anandwana001]

Looks like there is an issue with the _taskDataFlow in AbstractTaskViewModel

WhatsApp.Video.2024-09-18.at.07.36.47.mp4

[jabramowitz5]

@anandwana001 @jo-spek I do not think the behavior in this video is an error, but actually the survey "skipping" over the tasks that should be skipped due to the conditional answer to the "District:" question. The survey is "skipping" over the other potential child questions of the parent conditional. Probably ideally we don't want this to appear like this since it appears like skipping due to conditional and might confuse users, but less of an issue than the actual skipping occurring later in the survey (ie skipping take a photo, capture location, and a few other questions).

To clarify, there are required, non-conditional tasks that are being somehow skipped in the survey. So there is a skipping issue somewhere, I just don't think this video is displaying that true issue but instead proper conditional behavior (although the UI might be improved not show the "skipping" after conditional response to proper child question of parent conditional.

[gino-m]

This is likely due to the same cause as #2729 and #2727. Patch to SurveySelectorViewModel for @sufyanAbbasi:

  fun activateSurvey(surveyId: String) =
    viewModelScope.launch {
      runCatching {
          // Ignoring extra clicks while loading!
          if (_uiState.value is UiState.ActivatingSurvey) {
            return@runCatching
          }

[gino-m]

Fixed by #2740. @jabramowitz5 can you please add the "verified" label to this issue if this works once users remove and reopen their surveys without clicking the survey multiple times?