Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Code health] Invert control of data collection flow view models #2760

Open
gino-m opened this issue Sep 22, 2024 · 0 comments
Open

[Code health] Invert control of data collection flow view models #2760

gino-m opened this issue Sep 22, 2024 · 0 comments
Labels
type: code health Improvements to readability or robustness of codebase

Comments

@gino-m
Copy link
Collaborator

gino-m commented Sep 22, 2024

Currently, the container's view model (DataCollectionViewModel) is responsible for creating and managing the view models of the children tasks. Since these are passed through the constructor, this makes it impossible to restore the view on config change (#2725). Instead, child fragments need to get their own vms, probably from the parent fragment.

@shobhitagarwal1612 @scolsen @anandwana001

@gino-m gino-m added the type: code health Improvements to readability or robustness of codebase label Sep 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: code health Improvements to readability or robustness of codebase
Projects
Status: No status
Development

No branches or pull requests

1 participant