Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Display error toast or dialog when sign in fails #2830

Open
shobhitagarwal1612 opened this issue Nov 16, 2024 · 2 comments
Open

Display error toast or dialog when sign in fails #2830

shobhitagarwal1612 opened this issue Nov 16, 2024 · 2 comments
Assignees
Labels
for pm/ux review Product decision needed type: fr Request for new feature
Milestone

Comments

@shobhitagarwal1612
Copy link
Member

Current behavior:
Sign in request silent fails without any visible changes.

Expected behavior:
Show show some error toast or dialog message.

Note:
We only show a dialog if the sign in request fails due to permission denied error.

@shobhitagarwal1612 shobhitagarwal1612 added ux needed Product input from PM/UX needed for pm/ux review Product decision needed labels Nov 16, 2024
@gino-m gino-m added type: fr Request for new feature and removed ux needed Product input from PM/UX needed labels Dec 6, 2024
@gino-m
Copy link
Collaborator

gino-m commented Dec 6, 2024

I think a simple toast with "Sign in failed" is sufficient. Removing @rawbzz

@kenstershiro kenstershiro moved this to Todo in Ground Dec 13, 2024
@kenstershiro
Copy link
Collaborator

@shobhitagarwal1612 the uncovered case at the moment (sign in failing when it's not to do with permission denied) would be some sort of technical error like a timeout for example right? For setting the priority correctly I just wanted to be sure the most common case of incorrect credentials is already giving toast dialog.

@kenstershiro kenstershiro added this to the GA release milestone Dec 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
for pm/ux review Product decision needed type: fr Request for new feature
Projects
Status: Todo
Development

No branches or pull requests

4 participants