Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Geometry data collection tasks] Geometry sometimes not visible on map when returning to task #2847

Closed
gino-m opened this issue Nov 18, 2024 · 2 comments · Fixed by #2868
Closed
Assignees
Labels
type: bug Something isn't working

Comments

@gino-m
Copy link
Collaborator

gino-m commented Nov 18, 2024

This occurs when the viewport is updated after the task is complete, usually by a subsequent geometry task. Returning the the previous task, the viewport of the previous map is restored, which doesn't necessarily have the collected geometry in focus.

Instead, if the task already has data, we should set the initial viewport to the bounds of the geometry, perhaps one zoom level up (Z-1).

Screen_recording_20241119_100010.webm

Image

@kenstershiro @lecrabe @jabramowitz5 @anandwana001 FYI

@gino-m gino-m added the type: bug Something isn't working label Nov 18, 2024
@gino-m gino-m changed the title [Draw area task] Draw area UI in invalid state after restoring draft [Data collection] Photo and drawn area lost after restoring draft Nov 19, 2024
@gino-m gino-m added type: bug Something isn't working and removed type: bug Something isn't working labels Nov 19, 2024
@gino-m gino-m changed the title [Data collection] Photo and drawn area lost after restoring draft [Data collection] Photo and draw area lost after restoring draft Nov 20, 2024
@shobhitagarwal1612
Copy link
Member

I'm unable to repro this locally.
@gino-m Can we sync once for this issue?

@gino-m gino-m changed the title [Data collection] Photo and draw area lost after restoring draft [Geometry data collection tasks] Geometry sometimes not visible on current map when returning to task Nov 22, 2024
@gino-m
Copy link
Collaborator Author

gino-m commented Nov 22, 2024

@shobhitagarwal1612 Updated this bug title, description, and priority based on our discussion. PTAL?

@gino-m gino-m changed the title [Geometry data collection tasks] Geometry sometimes not visible on current map when returning to task [Geometry data collection tasks] Geometry sometimes not visible on map when returning to task Nov 22, 2024
@shobhitagarwal1612 shobhitagarwal1612 moved this to In Progress in Ground Nov 23, 2024
@github-project-automation github-project-automation bot moved this from In Progress to Done in Ground Nov 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: bug Something isn't working
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

2 participants