Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support --characters from a file #88

Open
madig opened this issue Aug 25, 2023 · 3 comments · May be fixed by #112
Open

Support --characters from a file #88

madig opened this issue Aug 25, 2023 · 3 comments · May be fixed by #112
Assignees

Comments

@madig
Copy link

madig commented Aug 25, 2023

I want to test the following chars:

!"#$%&'()*+,-./0123456789:;<=>?@ABCDEFGHIJKLMNOPQRSTUVWXYZ[\]^_`abcdefghijklmnopqrstuvwxyz{|}~ ¡¢£¥§¨©ª«®¯°²³´¶·¸¹º»¿ÀÁÂÃÄÅÆÇÈÉÊËÌÍÎÏÐÑÒÓÔÕÖ×ØÙÚÛÜÝÞßàáâãäåæçèéêëìíîïðñòóôõö÷øùúûüýþÿĀāĂ㥹ĆćĊċČčĎďĐđĒēĖėĘęĚěĞğĠġĢģĦħĪīĮįİıIJijĶķĹĺĻļĽľĿŁłŃńŅņŇňŊŋŌōŐőŒœŔŕŖŗŘřŚśŞşŠšŢţŤťŪūŬŭŮůŰűŲųŴŵŶŷŸŹźŻżŽžǍȘșȚțȷˆˇ˘˙˚˛˜˝ẀẁẂẃẄẅẞỲỳ –—‘’‚“”„•…‹›⁄⁰⁴⁵⁶⁷⁸⁹₀₁₂₃₄₅₆₇₈₉€™−◌

I can't though, because there's special characters in there, so I have to fight my shell's escaping rules and then ninja's (because the string is inserted verbatim). Please add a way to have the code read the characters from a file.

@madig
Copy link
Author

madig commented Aug 25, 2023

Oh, I have to escape them for regex parsing as well. Ugh.

@m4rc1e
Copy link
Collaborator

m4rc1e commented Oct 31, 2023

Sorry I've just seen this (had a kid born that day). I'll add this.

@m4rc1e m4rc1e self-assigned this Oct 31, 2023
@m4rc1e
Copy link
Collaborator

m4rc1e commented Nov 15, 2023

Apologies but the implementation of the --characters arg is probably different to what you expect. Currently, it expects regex ranges such as [0-9|A-z] in order for it to work. Your expression will work if it's encapsulated by [ and ] and the special regex characters such as ()[]{}-| are escaped by forward slashes. I'll still open a pr for you since having this in a file does make sense.

@m4rc1e m4rc1e linked a pull request Nov 15, 2023 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants