Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Non-standard extension should be behind flag #1221

Open
drott opened this issue Nov 5, 2024 · 2 comments
Open

Non-standard extension should be behind flag #1221

drott opened this issue Nov 5, 2024 · 2 comments

Comments

@drott
Copy link
Contributor

drott commented Nov 5, 2024

Compare #927

I would prefer if we kept not yet fully standardized extensions behind a flag to avoid breakage and being able to follow Chromium's release process.

@drott drott added this to the Skrifa for Chrome milestone Nov 5, 2024
@dfrg
Copy link
Member

dfrg commented Nov 11, 2024

We can either feature gate this or just mask out the cubic bit on read with a comment that it should be re-enabled when the spec finalizes. I lean toward the latter unless we have a case where we really need to parse cubic glyf outlines.

@rsheeter any preference?

@drott
Copy link
Contributor Author

drott commented Nov 12, 2024

I lean toward the latter [...]

Yes, let's move forward with that, could you do a PR? Thanks in advance.

dfrg added a commit that referenced this issue Nov 12, 2024
We don't want to ship experimental functionality in Chrome. Resolved per #1221 to mask out the bit and re-enable later. Also ignores two tests for this.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants