Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More systematic way to identify overflow #1287

Open
rsheeter opened this issue Dec 11, 2024 · 0 comments
Open

More systematic way to identify overflow #1287

rsheeter opened this issue Dec 11, 2024 · 0 comments
Assignees
Labels

Comments

@rsheeter
Copy link
Collaborator

Due to Chrome enabling overflow checks (https://doc.rust-lang.org/book/ch03-02-data-types.html#integer-overflow) we end up fighting overflow issues, most recently #1286.

We don't want to check the entire codebase for potential overflow, we want a targeted check. The overflow lint is apparently ill suited for the task because we cannot tell it that e.g. Fixed doesn't overflow.

So ... what can we do?

One idea might be to do a targeted scan of MIR? - https://blog.rust-lang.org/2016/04/19/MIR.html

Other ideas?

@rsheeter rsheeter changed the title More systematic way to identify overflo More systematic way to identify overflow Dec 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants