Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DS slider section broken for some slider names #821

Closed
justvanrossum opened this issue Sep 19, 2023 · 0 comments · Fixed by #822
Closed

DS slider section broken for some slider names #821

justvanrossum opened this issue Sep 19, 2023 · 0 comments · Fixed by #822
Labels
bug Something isn't working

Comments

@justvanrossum
Copy link
Collaborator

Regression caused by #805: the slider name is now directly used as an id for an element, and we use querySelector on it. This obviously breaks for axis names containing certain chars, such as *, like we use in NLI axes.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
Fontra Project
Status: ✅ Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Keep sliders as properties of an object instead of using element ids googlefonts/fontra
1 participant
@justvanrossum