Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unused media players? #49

Open
HelgeStenstrom opened this issue Jul 26, 2019 · 7 comments
Open

Unused media players? #49

HelgeStenstrom opened this issue Jul 26, 2019 · 7 comments

Comments

@HelgeStenstrom
Copy link
Contributor

HelgeStenstrom commented Jul 26, 2019

private MediaPlayer mediaPlayer;
private MediaPlayer soundPlayer;

What's the purpose of the two media players? Are they leftovers from old solutions?
It seams that you are not using JavaFx for the audio.

What are you using instead, and why?

@goxr3plus
Copy link
Owner

YES, I used to have some extra features like a background video and audio in Welcome screen, we might enable anytime in future so i left them there and all the code implementation :).

I think we will pass on Java 13 soon. I don't know what to do with JxBrowser and it's weird new non opensource licenses they have.

I might remove it all together and add JavaFX browser which though is very limited.

@HelgeStenstrom
Copy link
Contributor Author

I have my own little project, and yours is a source of inspiration. I will need visualization (like an oscilloscope and/or a spectrogram) visualizing playing music or sound from a microphone. But I haven't yet figured out how to update a graph from a sound channel. That's why I looked at MediaPlayer. What package or class are you using instead of MediaPlayer? (Yes, I can find it myself by reading the source code, but it's easier to ask :) )

@goxr3plus
Copy link
Owner

It's actually a little bit complex to explain. You should start reading the code of XR3PlayerController class and see thr @OverRide methods os StreamPlayerListener, there is all the magic :)

@HelgeStenstrom
Copy link
Contributor Author

That means mainly the progress() method in StreamController, which uses an instance of XPlayerController. Right?

@goxr3plus
Copy link
Owner

Yes actually you can start reverting the logic from there. The progress() is passing thr PCM data to the visualizer as you can see i give also the line to the visualizer.

It's simple as that. XR3PALAYER CONTROLLER has an instance of Visualizer which it uses. HEY

check java spectrum analyserz tutorials that i created in YouTube i explain there and i havr the code ready for you.

@HelgeStenstrom
Copy link
Contributor Author

Do you mean this one? https://www.youtube.com/watch?v=6r9Wu_OUbPc

@goxr3plus
Copy link
Owner

goxr3plus commented Jul 30, 2019

This one, i have a repository here :) https://github.com/goxr3plus/Java-Spectrum-Analyser-Tutorials

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants