Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Visualizers Drawers make application UI Freeze #51

Open
goxr3plus opened this issue Aug 1, 2019 · 3 comments
Open

Visualizers Drawers make application UI Freeze #51

goxr3plus opened this issue Aug 1, 2019 · 3 comments

Comments

@goxr3plus
Copy link
Owner

Due to heavy re-rendering that Visualizers of Players need ( 60FPS ) the application is freezing a lot of times making it hard or even not usable at all .

Investigation should be done on how to minimize or completely eliminate that behaviour.

@HelgeStenstrom This will be done probably completely because i don't know how much you understand the internals of JavaFX Canvas redrawing etc :) .

Holla the application is reaching 250 stars . Not bad :)

@HelgeStenstrom
Copy link
Contributor

I know very little about canvas usage. In my own little project I started to use it only recently. A few days ago I learnt how to draw lines an a canvas, so that I can display a sound spectrum while playing a song. Still learning.

@HelgeStenstrom
Copy link
Contributor

Some random thoughts: What is controlling the visualizer updating frequency? One or more AnimationTimers, perhaps? Is there too much work that has to be done in one update cycle (for one timer event)? Can the amount of effort be measured, like with a profiling tool? (I've never used a profiling tool for Java, and don't know what's available).

@goxr3plus
Copy link
Owner Author

@HelgeStenstrom I am not sure how it can be measured but definitely there is . Well there is JProfiler and VisualVM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants