- Add a second reviewer for complex new features or larger refactorings
- Code follows the coding style of CONTRIBUTING.md
- Tests follow the best practice for testing
- Changelog updated in the unreleased section including API breaking changes
- Branch follows the naming format (
iox-123-this-is-a-branch
) - Commits messages are according to this guideline
- Commit messages have the issue ID (
iox-#123 commit text
) - Commit author matches Eclipse Contributor Agreement (and ECA is signed)
- Commit messages have the issue ID (
- Update the PR title
- Follow the same conventions as for commit messages
- Link to the relevant issue
- Relevant issues are linked
- Add sensible notes for the reviewer
- All checks have passed (except
task-list-completed
) - All touched (C/C++) source code files from
iceoryx_hoofs
are added to./clang-tidy-diff-scans.txt
- Assign PR to reviewer
- Commits are properly organized and messages are according to the guideline
- Code according to our coding style and naming conventions
- Unit tests have been written for new behavior
- Public API changes are documented via doxygen
- Copyright owner are updated in the changed files
- All touched (C/C++) source code files from
iceoryx_hoofs
have been added to./clang-tidy-diff-scans.txt
- PR title describes the changes
- All open points are addressed and tracked via issues
- Closes TBD