Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

op: Fix alpha_to_coverage_mask test for Qualcomm #3960

Open
kainino0x opened this issue Sep 20, 2024 · 1 comment
Open

op: Fix alpha_to_coverage_mask test for Qualcomm #3960

kainino0x opened this issue Sep 20, 2024 · 1 comment

Comments

@kainino0x
Copy link
Collaborator

It fails on Qualcomm/Adreno because it's too strict. See explanation: gpuweb/gpuweb#4867

It's hard to imagine how to test this without the test being overly strict. I've been testing various platforms (see that issue) and maybe we can just update this test such that it will pass on all platforms we were able to test, e.g.:

  1. remove the extra requirement that samples not disappear as alpha increases - Adreno doesn't adhere to this
  2. rather than count the samples over a 1x1 area, count the samples some multiple of a 4x4 area - 4x4 the size of the block on Adreno, which is the largest I've seen so far
@kainino0x
Copy link
Collaborator Author

Here's a collection of different behaviors to make sure the test will allow:
https://drive.google.com/drive/folders/1WFpS09pu77qie5qWqJ0aUWNM3nWAYfFW?usp=drive_link

@kainino0x kainino0x added this to CTS Sep 20, 2024
@kainino0x kainino0x moved this to Open (no TODO) in CTS Sep 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Open (no TODO)
Development

No branches or pull requests

1 participant