Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set HTTP timeouts as downstream errors #1063

Merged
merged 6 commits into from
Aug 28, 2024
Merged

Set HTTP timeouts as downstream errors #1063

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
09bdebe
add timeout checks for downstream errors
wbrowne Aug 27, 2024
6e9d714
simplify
wbrowne Aug 27, 2024
46675be
add tests
wbrowne Aug 27, 2024
b76cd1c
add wrapped error cases
wbrowne Aug 27, 2024
5e9538f
update tests
wbrowne Aug 27, 2024
08014aa
Fix typo in comment
wbrowne Aug 27, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 11 additions & 0 deletions backend/error_source.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,9 @@ import (
"context"
"errors"
"fmt"
"net"
"net/http"
"os"
)

// ErrorSource type defines the source of the error
Expand Down Expand Up @@ -62,6 +64,15 @@ func IsDownstreamError(err error) bool {
return true
}

// if error is HTTP network timeout error, we should treat it as downstream error
if err, ok := err.(net.Error); ok && err.Timeout() {
wbrowne marked this conversation as resolved.
Show resolved Hide resolved
return true
}

if os.IsTimeout(err) {
wbrowne marked this conversation as resolved.
Show resolved Hide resolved
return true
}

return false
}

Expand Down