Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Transactions resulting in OptimisticLockingExcepetion are never committed nor rolled back #95

Open
amadfida opened this issue Aug 30, 2018 · 1 comment

Comments

@amadfida
Copy link

amadfida commented Aug 30, 2018

When OptimisticLockingException are thrown during session.flush() as part of doCommit(), it has been observed that those transactions are not rolled back and are left open and Neo4j server keep those transaction alive, and keeping any locks on objects as well. There so no default transaction timeout in Neo4j, hence resulting in complete lock till restart.

https://github.com/spring-projects/spring-framework/blob/master/spring-tx/src/main/java/org/springframework/transaction/support/AbstractPlatformTransactionManager.java#L128 seems that we should set that to true in Neo4jDatastoreTransactionManager to handle roll backs during commit failures.

@amadfida amadfida changed the title TX resulting OptimisticLockingExcepetion are never committed nor rolled back Transactions resulting in OptimisticLockingExcepetion are never committed nor rolled back Aug 30, 2018
@amadfida
Copy link
Author

@graemerocher @jameskleeh please let me know if you need more info.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant