Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Grade issues #16

Open
dberlow opened this issue Jun 29, 2021 · 0 comments
Open

Grade issues #16

dberlow opened this issue Jun 29, 2021 · 0 comments

Comments

@dberlow
Copy link
Collaborator

dberlow commented Jun 29, 2021

On the Grades menu of the demo...

I am not seeing much difference in any of the grade options B on W.
4
3
2
1

I can see the difference between the two above. . .
D4
D3
and assume there would not be a difference between the two below.
D2
D1

But the grade function has not yet caught up with the intent of its use, which is to be automated.

With that, Dark Mode Grade adjustment needs to have

  1. an on/off and reset as you have it,
  2. “Amplify” is not needed, nor is the “X”
  3. and the values for the slider need to be taken from the font, which is in wght units, i.e. -/+ from 400 (amstelvar’s current values are GRAD -300, 0, 500).
    (right now, I think it’s only applying positive grade values?)
  4. the value associated with Amstelvar use at various sizes is in the enclosed pdf. and should be applied automatically.

So if the user selects dark mode, then the garde suggested is aplied.
If the user want to change that and see another valuu they can.

Turning it on an off sets it to the suffested value.

Reset sets it to the axis default of 0.

Let me know if there are issues with this issue, thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant