Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ENH] Optional creds via CloudFormation param #33

Open
lmeyerov opened this issue Feb 23, 2021 · 5 comments
Open

[ENH] Optional creds via CloudFormation param #33

lmeyerov opened this issue Feb 23, 2021 · 5 comments
Assignees
Labels
enhancement New feature or request

Comments

@lmeyerov
Copy link
Contributor

lmeyerov commented Feb 23, 2021

Instead of doing the public IP lookup (https://github.com/graphistry/graph-app-kit/blob/master/src/bootstraps/neptune/graphistry.sh#L45), which does not work in some modes, we should support:

  1. an optional CloudFormation setting of initial admin's user/password
  • ... be sure to skip the IP lookup as it may fail in locked-down accounts
  1. when not provided, fallback to lookup

See: #32, #31, #28

@shehabgamin
Copy link

@lmeyerov Amazing thanks!

How long can we except for this enhancement to be ready?

I would like to start visualizing my production data but can't due to security concerns

@lmeyerov
Copy link
Contributor Author

lmeyerov commented Feb 24, 2021

@aminsshahab I'm checking w/ our AWS collaborators for guidance -- assuming not complicated, maybe end-of-week / next?

I think the private subnet thing is:

  1. If creds specified, remove INSTANCE ID public IP lookup and its use for default creds:
  1. Add optional provisioning of user-specific creds:

However, I'm fuzzy on the surrounding public/private VPC stuff. Ex: If we did the above change, and you picked a private VPC... would that be enough.. or is there more needed?

FWIW, are you connecting this w/ Neptune or anything?

@shehabgamin
Copy link

shehabgamin commented Mar 2, 2021

@lmeyerov My apologies for the late response.

A VPC is an isolated virtual network within AWS. For an EC2 instance you can decide to choose a public subnet which exposes the instance to the internet, or you can choose to only have a private subnet which only allows the instance to be accessible through your VPC.

Within the cloud-formation stack, you can have the user choose a private subnet or a public subnet. If the user chooses a private subnet then all you would need to do is use the private ip instead of the public ip.

Also, yes I will be using this to connect to Neptune.

@lmeyerov
Copy link
Contributor Author

lmeyerov commented Mar 2, 2021

Great -- and how would web browsers access your graph-app-kit instance... say via an AWS-friendly VPN that allows access to the private IP, or maybe a public ELB that has access to the private IP?

I'm trying to suss out if there's anything else we should be adding, or it's sufficient to remove to the disallowed instance-id.sh call. Ex: Should we also provide an optional param for doing an ELB hookup of some sort.

@shehabgamin
Copy link

@lmeyerov Web browsers can access the instance using a VPN that has access to the VPC, which is the most straight forward way to do it.

@lmeyerov lmeyerov added this to Queued in March planning Mar 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Development

No branches or pull requests

2 participants