Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

META: Highlight & Selection write API - prototype #145

Open
4 of 7 tasks
lmeyerov opened this issue Mar 3, 2023 · 5 comments
Open
4 of 7 tasks

META: Highlight & Selection write API - prototype #145

lmeyerov opened this issue Mar 3, 2023 · 5 comments
Assignees
Labels
api enhancement New feature or request meta P3

Comments

@lmeyerov
Copy link
Contributor

lmeyerov commented Mar 3, 2023

Enable embedding users to trigger fast highlights & selections of items

Ex:

  • User hovers over a name or group ID in outside tool
  • Outside tool identifies corresponding node & edge IDs of interest
  • Graphistry UI highlights those specific nodes/edges
  • User clicks the name or group ID in outside tool
  • Graphistry UI selection focuses on those (sticky)
  • User clicks filter/exclude/... or other action for interacting with that selected subset
  • If user didn't click, but instead mouse-out'd, up to UI to return Highlight state to empty

Out-of-scope: Prototype will -

  • Work on internal entity Index, not ID, for PR. Index is the most recent index returned by the selection API.
  • Only highlight/select the exact

Piggybacks on selection API work

@lmeyerov lmeyerov added the P3 label Mar 3, 2023
@lmeyerov lmeyerov self-assigned this Mar 3, 2023
@lmeyerov lmeyerov added enhancement New feature or request api meta labels Mar 3, 2023
@exrhizo
Copy link

exrhizo commented Mar 14, 2023

Bugs are:

  • When you inject a selection it causes a bunch of events, as many as 10.

  • When you inject a selection, the onSelectionUpdate can have the wrong selection.labels

  • hovering over the nodes to get thier label causes the above to fix it also causes the onSelection to flicker

These didn't reproduce for me with ./nc

@lmeyerov
Copy link
Contributor Author

What does "hovering over the nodes to get thier label causes the above to fix it" mean? That the wrong label is shown, and hovering triggers an update that will show the correct one? I wonder if that means we're properly invalidating the label cache, but not subscribing to the invalidations properly in the labels container / triggering the wrong rendering effects for the rendering scheduler?

@lmeyerov
Copy link
Contributor Author

lmeyerov commented Mar 14, 2023

I was actually more worried about filter states messing up local vs global indexing, so the above feels more doable :)

@lmeyerov
Copy link
Contributor Author

@exrhizo I lost track, can you share status here?

@lmeyerov
Copy link
Contributor Author

(I think this one is paused pending Gadi's feedback)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api enhancement New feature or request meta P3
Projects
None yet
Development

No branches or pull requests

2 participants