Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] fix notebooks top level directory persistence #43

Open
webcoderz opened this issue May 25, 2023 · 11 comments
Open

[BUG] fix notebooks top level directory persistence #43

webcoderz opened this issue May 25, 2023 · 11 comments
Assignees
Labels
bug Something isn't working p1

Comments

@webcoderz
Copy link
Contributor

Describe the bug
Fix notebooks top level directory so files are persisted in between restarts.

@webcoderz webcoderz added the bug Something isn't working label May 25, 2023
@lmeyerov
Copy link
Contributor

lmeyerov commented May 25, 2023

Oh is this not happening? that seems like a k8s p1 (enterprise release blocker)

@lmeyerov lmeyerov added the p1 label May 25, 2023
@webcoderz
Copy link
Contributor Author

image
inside all of these directories are persistent, just the top level currrent dir is not , i just have to add an extra mount point or something here

@lmeyerov
Copy link
Contributor

Ping

@webcoderz
Copy link
Contributor Author

Oh yea will fix tommorow before release.

@webcoderz
Copy link
Contributor Author

Easy fix

@lmeyerov
Copy link
Contributor

@webcoderz can we close?

@webcoderz
Copy link
Contributor Author

No Percy was going to work on it after OT

@webcoderz
Copy link
Contributor Author

Since I don't need arcos for a while I'll unmount those volumes and continue testing with new volumes so no data loss on Monday

@lmeyerov
Copy link
Contributor

ok tho can't spend a lot of cycles here, he needs to move on to horiz scaling

@aucahuasi
Copy link
Contributor

No Percy was going to work on it after OT

Yes, this task was part of my TODO list, but I could not allocate time yet.
Now that I finished some PRs I can take a look here.

Easy fix

@webcoderz I remember the issue, if you have any advice on the points I need to touch, let me know please.

@lmeyerov
Copy link
Contributor

let's finish otel stuff first just b/c bbai deploy deadline, tho yeah if you have idle cycles to scope this out in prep, that sounds useful!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working p1
Projects
None yet
Development

No branches or pull requests

3 participants