Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Export privacy settings as enums not types #122

Open
lmeyerov opened this issue Apr 6, 2023 · 0 comments
Open

Export privacy settings as enums not types #122

lmeyerov opened this issue Apr 6, 2023 · 0 comments
Assignees
@lmeyerov
Labels
enhancement P3 Useful - Part of a quality implementation of a feature or useful for a particular customer

Comments

@lmeyerov
Copy link
Contributor

lmeyerov commented Apr 6, 2023 •
edited
Loading

Client users manipulating security settings can pass in private / organization / etc, but for type safety, cleaner if they can use an exported mode enum. Currently we only expose mode as a type.

See also internal dogfooding discussion: https://github.com/graphistry/graphistry/pull/1910#discussion_r1159384204

This is probably better as a breaking change to avoid confusing redundancy
@lmeyerov lmeyerov added enhancement P3 Useful - Part of a quality implementation of a feature or useful for a particular customer labels Apr 6, 2023
@lmeyerov lmeyerov self-assigned this Apr 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lmeyerov lmeyerov

Labels
enhancement P3 Useful - Part of a quality implementation of a feature or useful for a particular customer
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@lmeyerov