Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

avoid using native-tls in dependencies #325

Closed
pete-eiger opened this issue May 23, 2024 · 0 comments · Fixed by #327
Closed

avoid using native-tls in dependencies #325

pete-eiger opened this issue May 23, 2024 · 0 comments · Fixed by #327
Assignees
Labels
p1 High priority size:medium Medium

Comments

@pete-eiger
Copy link
Contributor

pete-eiger commented May 23, 2024

As discovered in graphops/subgraph-radio#147 , native-tls is causing memory leak issues in Subgraph Radio. It it used in three of our dependencies - reqwest, teloxide and slack-morphism. reqwest is already dealt with by switching the dependency definition from

reqwest = { version = "0.11.17", features = ["json"] }

to

reqwest = { version = "0.11.24", features = ["json", "rustls-tls"] }

But it might not be so straightforward for the other two. If we can't configure them to use rustls instead of native-tls, we should find alternative crates or methods to support Slack and Telegram bot functionalities.

@pete-eiger pete-eiger self-assigned this May 23, 2024
@pete-eiger pete-eiger added size:medium Medium p1 High priority labels May 23, 2024
@pete-eiger pete-eiger linked a pull request May 24, 2024 that will close this issue
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
p1 High priority size:medium Medium
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant