Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

📣 Call for maintainers #1312

Open
jkimbo opened this issue Mar 1, 2021 · 40 comments
Open

📣 Call for maintainers #1312

jkimbo opened this issue Mar 1, 2021 · 40 comments

Comments

@jkimbo
Copy link
Member

jkimbo commented Mar 1, 2021

Unfortunately it seems that the current maintainers of Graphene no longer have the time to maintain the library so I'm taking the liberty of putting out this call for anyone who wants to get involved with development. Ideally you'll already have already contributed to this library in some way or another.

The current status of the library is:

  • v3 is ready to be released (☂️ Graphene v3 #1127) but has stalled because of a desire to bring the various dependant libraries up to date with it first. It's my opinion that v3 should just be released without waiting since it's been in the works for more than 6 months and it's now just stagnating. I will leave that up the new maintainers to make that call though since it will probably require some support once it's been released. Release notes are here: https://github.com/graphql-python/graphene/wiki/v3-release-notes
  • The current master branch tracks the v3 beta releases and there is a v2 branch for bugfixes for v2 (https://github.com/graphql-python/graphene/tree/v2)
  • The release process is as follows:
  • The current documentation is very sparse and needs work to make it more useful
  • While Graphene is currently feature complete in terms of creating a compliant GraphQL server, it is lacking a lot of features that developers would expect from a mature GraphQL server library. There is a lot of scope to improve things here.
  • There a quite a few gotchas with the API and it can cause a lot of confusion for people who are new to the library. Some of these are outlined here: Explain non-pythonic design and structures #612 (comment)
  • Generally issues and pull requests have gone unanswered for quite a while know so there is a lot of housekeeping to do as well

Please reply to this issue if you would like to help out with maintaining this library. Once we have a couple of interested people I'll give you admin access and then let you self organise with how you want to proceed.

@jkimbo jkimbo pinned this issue Mar 1, 2021
@jkimbo jkimbo mentioned this issue Mar 1, 2021
8 tasks
@Speedy1991
Copy link

Working with graphene for about 4 years (also giving workshops ) . I don't have the time to maintain, but willing to review PR's and support with issues/questions

@roylanmartinez
Copy link

I have been using Django graphene for at least 4 months so far. I think Graphene is incredibly useful and despite of that it is incredibly underrated. I do not have full time availability but I would like to contribute with this great library maybe building up a page of this repository with a clearer and more complete documentation or something similar.

@AndreCimander
Copy link

Maybe https://jazzband.co/ is a good fit?

@rhizoome
Copy link
Contributor

rhizoome commented Mar 6, 2021

Our project caluma uses graphene, we are committed to it. I wanted to help the project last year, but I wasn't able put much time in. I will talk to the team next week.

@berkcoker
Copy link

I can also contribute by reviewing PRs. We have been using graphene for over a year

@reginafcompton
Copy link

One of our repos at Brighthive uses Graphene; we've used Graphene for about 6 months. I am interested and (hopefully) able to contribute by: reviewing PRs and writing documentation.

@kevindice
Copy link

I'm interested in helping.

@jkimbo
Copy link
Member Author

jkimbo commented Mar 24, 2021

Thank you everyone. Any help if much appreciated.

@ganwell since you've contributed in the past it would be great to hand over things to you and your team. Could you either join Slack to chat more about it? Or email me, my email is on my GitHub profile.

@jkimbo
Copy link
Member Author

jkimbo commented Apr 6, 2021

@syrusakbary I'm going to leave this for you to take over now since you've said you're going to devote some more time to the project (I had assumed you weren't able to)

@syrusakbary
Copy link
Member

Small update. We started using Graphene at Wasmer, so expect news to come soon regarding updates to the codebase and so :)

@jmorenobl
Copy link

Hello guys! is this repository officially dead? it has past 2 months from the last message written by @syrusakbary and still no movement. Can anyone confirm?

@kevindice
Copy link

@jmorenobl Seems like we absolutely have community interest in continuing this project. Forking is an option, but ideally, some of us can get added to the GH org.

@jmorenobl
Copy link

I agree with you @kevindice, seems like there is interest in this project. I'm certainly interested and I'm also interested in helping... what do we need to do? I'm not sure if I have the right background to help here but I can try. I'm using graphene-django and I want to keep using it. I don't like the alternatives.

@aryaniyaps
Copy link
Contributor

I am interested in helping to release Graphene v3. It's been a very long time.

@richin13
Copy link

Any updates here? Looks like there's an effort to move things forward here with some of us willing to take over and recover this community

@allangz
Copy link

allangz commented Oct 8, 2021

Hi guys, I also would like to help.

@jmorenobl
Copy link

Hello guys! Is there any roadmap for graphene v3? It seems to be some movement on the project but the documentation is outdated, the are many PRs and Issues. It would nice to have some info on the priorities and maybe more people can help.

@jamietdavidson
Copy link
Collaborator

Hey guys,

I have been working with graphene for over 2 years now, and have written a handful of custom mutation subclasses, logging classes, authentication integrations, and websocket integrations + tests, and have a handful of design patterns that i've found make working with graphene / django a lot easier (that I had to develop from scratch!).

I would love to bring this code into graphene and make it readily available.

Best,
James Davidson

@theodesp
Copy link

I'm also interested in contributing here. I can triage issues, review PRs and fix bugs. Count me in!

@djstein
Copy link

djstein commented Jun 19, 2022

hi @jkimbo ! I am back on the open source train after leaving Apple this week and will be using Graphene as the core infrastructure at my new position. I would love to contribute as much as possible to this package.

I have been using Graphene for the past 4 years, and follow in @jamietdavidson's comments, where I have made advanced additions to Graphene in my apps via request logging, authentication, websockets via subscriptions + Django Channels, testing, among other topics.

I use Graphene based APIs in Python CLI tools as well as the GraphQL Code Generator (https://www.graphql-code-generator.com) to make premade TypeScript SDKs for NextJS apps.

@jamietdavidson
Copy link
Collaborator

@djstein @jkimbo Would either of you be interested in setting up a call later this week?

We can start the handoff process & start kicking this into high gear.

@djstein
Copy link

djstein commented Jun 20, 2022

@jamietdavidson @jkimbo I am free to chat, the quickest way to reach me is on Twitter at (https://twitter.com/d_j_stein)

@jkimbo
Copy link
Member Author

jkimbo commented Jun 21, 2022

Great @djstein @jamietdavidson ! Are you both on the Slack workspace? It would be easier to coordinate things there with @tcleonard who has been picking up maintenance recently.

@erikwrede
Copy link
Member

@djstein @jamietdavidson @tcleonard let me know when you schedule a call, currently working on Graphene-SQLAlchemy and would be happy to assist where I can :)

@jamietdavidson
Copy link
Collaborator

jamietdavidson commented Jun 22, 2022

@erikwrede @djstein @jkimbo on Monday, June 27th***, at 11:00 AM PDT, I will be on this Google meet link: https://meet.google.com/ieu-wtxe-tqe

I’ll leave it open for anyone who would like to join. I wish GitHub had direct messages, as I don’t feel comfortable sharing my email on a public thread.

Let’s review and talk about things there! If anyone needs to reschedule, you can also reach me on twitter (jameztdavidson).

Talk soon!

@erikwrede
Copy link
Member

@jamietdavidson see you there!
Also reposting the invite to the graphene-slack workspace :) Sharing a mail address should be more private there. Feel free to reach out!

https://join.slack.com/t/graphenetools/shared_invite/enQtOTE2MDQ1NTg4MDM1LTA4Nzk0MGU0NGEwNzUxZGNjNDQ4ZjAwNDJjMjY0OGE1ZDgxZTg4YjM2ZTc4MjE2ZTAzZjE2ZThhZTQzZTkyMmM

@erikwrede
Copy link
Member

@jamietdavidson sent a request to join, are you on the call?

@djstein
Copy link

djstein commented Jun 27, 2022

sorry gang @jamietdavidson @erikwrede , didn't realize the call was at 11 AM, pretty busy with work today. can we schedule a 5PM chat?

@erikwrede
Copy link
Member

erikwrede commented Jun 27, 2022

@djstein that's 2am CEST so I sadly won't be able to make it. Nevertheless, you are invited to contact me on the Graphene slack and I'll bring you up to speed ASAP :)

@felixmeziere
Copy link

@djstein thanks for existing! ❤️❤️❤️ we were lost here

@erikwrede
Copy link
Member

Hey everyone,
We are trying to get things sorted right now and want to get started by adding some new features to graphene & overhaul documentation.
This issue will stay open as we are still looking for additional helpers!
Please contact me (Erik Wrede) directly on the Graphene Slack if you want to help out 🙂.
If there's an old PR stuck waiting for review that you feel is ready to merge, feel free to tag me and I'll check it out.

@oliver-sanders
Copy link

oliver-sanders commented Jan 12, 2024

Hi there 👋,

Some of the other graphql-python repos are currently unmaintained, graphql-ws has a few PRs backed up. I'll try and review what I can and test against my use case. Would anyone with write permissions be able to drop in, particularly for these two which should be good to go:

There's also an abandoned attempt to upgrade to graphql-core v3 graphql-python/graphql-ws#43 :(

@erikwrede
Copy link
Member

Hey @oliver-sanders, awesome that you want to help out! Can you drop me a DM on the graphene discord or just write on the general channel - I'll find you there 😊

Cross-referencing @kiendang, he's working on graphql-server and long term the best solution is to merge it with graphql-ws.

@jtc3161
Copy link

jtc3161 commented Apr 17, 2024

@oliver-sanders @erikwrede, I haven't contributed to this repo before since it was already mostly unmaintained when I started on my most recent backend project, but would love to help out where I can. I've been maintaining a fork of graphql-ws-aiohttp for years which supports graphql-core v3, graphql-transport-ws and would really support the effort to bring websocket support native to graphql-server. The graphql-ws-aiohttp library is also unmaintained hence the fork.

@erikwrede
Copy link
Member

@jtc3161 If you're interested in helping out on the Graphene Server / WS integrations, please contact @kiendang on the Graphene discord. He's the best person to ask on this 😊

@oliver-sanders
Copy link

Unfortunately, I can't access Discord from my network so wont be able to join you there. I'm not in a great place to help (no knowledge of the core library), but would also love to do what I can to help out.

On the subject of graphql-ws, I have reviewed this one:

Additionally, I think these are ready to go (two are mine):

I can also help prepare for release as needed. Just need someone with merge permissions to drop by.

Collecting integrations into a single graphql-server repo sounds a reasonable idea, however, there appears to be a blocker for graphene-tornado to migrate (graphql-python/graphql-server#25).

@ptfpinho23
Copy link

A bit late to the party, but willing to help in whatever I can, we've been using it in production for a long while. Just messaged @kiendang on discord.

@kiendang
Copy link
Contributor

@oliver-sanders @ptfpinho23 Sorry this slipped my attention. As Erik said I think it's a good move to migrate graphql-ws to graphql-server. However, I don't have time to do this work. If this is of interest to you, you're very welcome to submit a PR to graphql-server. I and Erik would be happy to review.

no knowledge of the core library

There is a separate effort to add websocket support to graphql-server in the v3 branch which you can use as reference to start.

@ptfpinho23
Copy link

ptfpinho23 commented May 18, 2024

As Erik said I think it's a good move to migrate graphql-ws to graphql-server. However, I don't have time to do this work. If this is of interest to you, you're very welcome to submit a PR to graphql-server. I and Erik would be happy to review.

@kiendang @erikwrede
Already took a look, definitely can help there; I'll take that over

@dulmandakh
Copy link
Contributor

@syrusakbary @erikwrede I would like to help with maintenance

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests