-
Notifications
You must be signed in to change notification settings - Fork 823
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tests in graphene/relay/tests/test_custom_global_id.py
fail due incompatibility with pytest 8.x
#1539
Labels
Comments
Thanks for reporting this! 😊 Seems like we need to upgrade this. Do you have time to work on a PR? @tijuca |
erikwrede
added a commit
that referenced
this issue
Jun 13, 2024
…m_global_id.py (#1539) (#1540) pytest: Don't use nose like syntax The tests in test_custom_global_id.py use the old nose specific method 'setup(self)' which isn't supported anymore in Pytest 8+. The tests fail with this error message without modification. E pytest.PytestRemovedIn8Warning: Support for nose tests is deprecated and will be removed in a future release. E graphene/relay/tests/test_custom_global_id.py::TestIncompleteCustomGlobalID::test_must_define_resolve_global_id is using nose-specific method: `setup(self)` E To remove this warning, rename it to `setup_method(self)` E See docs: https://docs.pytest.org/en/stable/deprecations.html#support-for-tests-written-for-nose Co-authored-by: Erik Wrede <erikwrede@users.noreply.github.com>
it should be fixed with #1540 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Running the test suite, in particular the tests in
graphene/relay/tests/test_custom_global_id.py
fail if pytest 8.x is used.The root for this behavior is the usage of
setup(self)
within the class definitions in that file which is nose specific syntax. The solution is rather simple and already written within the error message as the solution for the failing tests.Please tell us about your environment:
The text was updated successfully, but these errors were encountered: