Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[OTHER] Tests for Hubspot Driver in @daffodil/contact and @daffodil/newsletter don't test their behaviors adequately #1212

Open
damienwebdev opened this issue Jan 10, 2021 · 0 comments · May be fixed by #2447
Open

[OTHER] Tests for Hubspot Driver in @daffodil/contact and @daffodil/newsletter don't test their behaviors adequately #1212

damienwebdev opened this issue Jan 10, 2021 · 0 comments · May be fixed by #2447
Assignees
@griest024 @damienwebdev
Labels
🚨 breaking changes This PR or issue will cause a breaking change needs more info This issue needs more information p1 critical priority package: contact @daffodil/contact package: newsletter @daffodil/newsletter
Milestone
Daffodil v1.0

Comments

@damienwebdev
Copy link
Member

❓ Other

Environment


Daffodil version: X.Y.Z
Angular version: X.Y.Z 

 
For Tooling issues:
- Node version: XX  
- Platform:  

Others:
@damienwebdev damienwebdev added package: newsletter @daffodil/newsletter package: contact @daffodil/contact labels Jul 29, 2021
@damienwebdev damienwebdev linked a pull request Dec 19, 2023 that will close this issue
Open
3 tasks
@AnnieMi888 AnnieMi888 added this to the Daffodil v1.0 milestone Dec 19, 2023
@AnnieMi888 AnnieMi888 added p1 critical priority 🚨 breaking changes This PR or issue will cause a breaking change labels Dec 19, 2023
@AnnieMi888 AnnieMi888 added the needs more info This issue needs more information label Dec 19, 2023
@damienwebdev damienwebdev linked a pull request Jan 3, 2024 that will close this issue
feat(newsletter, contact) strengthen types and remove generics #2447
Open
3 tasks
@damienwebdev damienwebdev moved this to To do in Backlog Jun 13, 2024
@damienwebdev damienwebdev removed this from Backlog Oct 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@griest024 griest024

@damienwebdev damienwebdev

Labels
🚨 breaking changes This PR or issue will cause a breaking change needs more info This issue needs more information p1 critical priority package: contact @daffodil/contact package: newsletter @daffodil/newsletter
Projects
None yet
Milestone
Daffodil v1.0
Development

Successfully merging a pull request may close this issue.

feat(newsletter, contact) strengthen types and remove generics graycoreio/daffodil
5 participants
@griest024 @hanmindev @damienwebdev @Nolan-Arnold @AnnieMi888