Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider to add support for IP2Location.io as a fallback #95

Open
ip2location opened this issue Sep 13, 2024 · 7 comments
Open

Consider to add support for IP2Location.io as a fallback #95

ip2location opened this issue Sep 13, 2024 · 7 comments

Comments

@ip2location
Copy link

Hi there,

Would you like to add support of our service into your project? Our service provided 500 queries per day for keyless query, or 30000 queries per month if you sign up our free plan. You can read more on the result returned via our documentation.

@ribalba
Copy link
Member

ribalba commented Sep 13, 2024

Hey, thank you for the issue. I just looked at the documentation and I have a question. For ip it says (required) IP address (IPv4 or IPv6) for reverse IP location lookup purposes. If not present, the server IP address will be used for the location lookup. How can it be required but then there is a sentence if not present and if it is not present which server will be used. Is it just the source ip of the packet?

Also with key it said that it is required but before you stay that you can 500 queries without.

Sorry for nitpicking.

@ip2location
Copy link
Author

Hi ribalba,

  1. If the IP parameter is not present during the query, our API will the IP address of the source to perform geolocation lookup. For instance, if the request is coming from a personal computer, the personal computer's IP address will be used. If the request is coming from a server instead, the server's IP address will be used.
  2. In the rate limiting section of our doc, we had stated that we support keyless method to query our API with a limitation of 500 times per day. If you exceed the 500 queries limit, you will be needed to use our API key if you wish to continue query our API before the keyless limit get reset. Hence the API key is required in this situation.

@ribalba
Copy link
Member

ribalba commented Sep 13, 2024

Brilliant thank you.

We used to support multiple services, but this was removed at some stage in refactoring. I will talk to the team if it makes sense to reintroduce multiple IP services. (@ArneTR)

If you want to help a PR would be more than welcome :)

@ArneTR
Copy link
Member

ArneTR commented Sep 13, 2024

I am in favor of integrating a fail-over.

@ribalba Is there currently a way to know if / how often the current provider is flaking?

@ip2location I chip in on Didis notion and we would very much appreciate a PR :)

@ip2location
Copy link
Author

Hi @ArneTR,

Sorry for late reply! We are testing on our side before creating the PR, meanwhile can you let us know which branch should we target for the PR?

@ArneTR
Copy link
Member

ArneTR commented Sep 20, 2024

Please target the main branch. We will run the pipline and integration tests from that branch

@ip2location
Copy link
Author

Hi @ArneTR,

Thanks for the reply. We had submitted a PR regarding our API.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants