Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check if database is created completely #494

Open
ribalba opened this issue Oct 1, 2023 · 0 comments
Open

Check if database is created completely #494

ribalba opened this issue Oct 1, 2023 · 0 comments
Assignees
Labels
enhancement New feature or request

Comments

@ribalba
Copy link
Member

ribalba commented Oct 1, 2023

While refactoring an index condition wasn't updated:

https://github.com/green-coding-berlin/green-metrics-tool/blame/6df80f107d8c9a1733d5b431e51fb7034d5fd158/docker/structure.sql#L161

https://github.com/green-coding-berlin/green-metrics-tool/blame/6df80f107d8c9a1733d5b431e51fb7034d5fd158/docker/structure.sql#L173

which didn't show up in the tests as we currently don't have any tests for the hog. So the docker container would create the tables and then bail on the faulty index condition not creating the following stuff. We should have a test that the structure.sql runs in one transaction and doesn't fail.

There are a few ways we can do this.

  1. write a test that checks if the script runs without errors
  2. put the structure.sql in one transaction
  3. there are more.... to discuss in person on a Tuesday
@ArneTR ArneTR added the enhancement New feature or request label Jan 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants