Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Efficiency of the Garbage Collection #88

Open
JordiManyer opened this issue Jan 11, 2023 · 1 comment
Open

Efficiency of the Garbage Collection #88

JordiManyer opened this issue Jan 11, 2023 · 1 comment
Assignees
Labels
enhancement New feature or request

Comments

@JordiManyer
Copy link
Member

Hello all,

@amartinhuertas and me have been working on a Geometric MultiGrid solver/preconditioner for Gridap. To solve the coarsest-level linear system in parallel, we decided to use MUMPS through a PETScLinearSolver from GridapPETSc.

While profiling the resulting algorithm for a Poisson problem, where we use a preconditioned Conjugate Gradient solver with our GMG preconditioner, we find that a weirdly high amount of time is spent in the method gridap_petsc_gc(), which is called from within solve!() at every iteration of the conjugate gradient.

Due to this, we think it could be advantageous to introduce a new flag/kwarg/setting that deactivates all these automatic calls to the GC that are scattered around the code. The idea is to give an advanced user/developer the ability to manually call the GC optimally depending on the application.

Thanks!

@JordiManyer JordiManyer added the enhancement New feature or request label Jan 11, 2023
@JordiManyer JordiManyer self-assigned this Jan 11, 2023
@amartinhuertas
Copy link
Member

Thanks for reporting @JordiManyer ! Could you confirm if removing the call to gridap_petsc_gc() the hot spot/bottleneck disappears/is atenuated?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants