From a089b33820173d37dff4be8e45e23e231628cd58 Mon Sep 17 00:00:00 2001
From: ialokim <ialokim@mailbox.org>
Date: Thu, 11 Jan 2024 23:57:38 +0100
Subject: [PATCH] fix some theming-related issues

fixes #913, #909
---
 .../java/de/grobox/transportr/settings/SettingsFragment.kt | 4 ++--
 .../java/de/grobox/transportr/settings/SettingsManager.kt  | 7 +++++--
 app/src/main/res/xml/preferences.xml                       | 2 +-
 3 files changed, 8 insertions(+), 5 deletions(-)

diff --git a/app/src/main/java/de/grobox/transportr/settings/SettingsFragment.kt b/app/src/main/java/de/grobox/transportr/settings/SettingsFragment.kt
index f72f78c73..57a0cc0ff 100644
--- a/app/src/main/java/de/grobox/transportr/settings/SettingsFragment.kt
+++ b/app/src/main/java/de/grobox/transportr/settings/SettingsFragment.kt
@@ -60,9 +60,9 @@ class SettingsFragment : PreferenceFragmentCompat() {
 
         // Fill in current transport network if available
         networkPref = findPreference("pref_key_network")!!
-        manager.transportNetwork.observe(this, Observer<TransportNetwork> {
+        manager.transportNetwork.observe(this) {
             onTransportNetworkChanged(it)
-        })
+        }
 
         networkPref.setOnPreferenceClickListener {
             if (activity == null || view == null) return@setOnPreferenceClickListener false
diff --git a/app/src/main/java/de/grobox/transportr/settings/SettingsManager.kt b/app/src/main/java/de/grobox/transportr/settings/SettingsManager.kt
index c1f9cc628..0cd726a25 100644
--- a/app/src/main/java/de/grobox/transportr/settings/SettingsManager.kt
+++ b/app/src/main/java/de/grobox/transportr/settings/SettingsManager.kt
@@ -67,8 +67,11 @@ class SettingsManager @Inject constructor(private val context: Context) {
 
     val isDarkTheme: Boolean
         get() {
-            return (context.resources.configuration.uiMode and Configuration.UI_MODE_NIGHT_MASK == Configuration.UI_MODE_NIGHT_YES) or
-                    (theme == MODE_NIGHT_YES)
+            return when(theme) {
+                MODE_NIGHT_YES -> true
+                MODE_NIGHT_NO -> false
+                else -> context.resources.configuration.uiMode and Configuration.UI_MODE_NIGHT_MASK == Configuration.UI_MODE_NIGHT_YES
+            }
         }
 
     val walkSpeed: WalkSpeed
diff --git a/app/src/main/res/xml/preferences.xml b/app/src/main/res/xml/preferences.xml
index 8dfa735f1..172952f0e 100644
--- a/app/src/main/res/xml/preferences.xml
+++ b/app/src/main/res/xml/preferences.xml
@@ -49,7 +49,7 @@
 		app:iconSpaceReserved="false">
 
 		<ListPreference
-			android:defaultValue="@string/pref_theme_value_light"
+			android:defaultValue="@string/pref_theme_value_auto"
 			android:entries="@array/pref_theme_options"
 			android:entryValues="@array/pref_theme_values"
 			android:key="pref_key_theme"