Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

API coverage checklist #1

Open
not-so-smart opened this issue Aug 14, 2021 · 2 comments
Open

API coverage checklist #1

not-so-smart opened this issue Aug 14, 2021 · 2 comments
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed

Comments

@not-so-smart
Copy link
Member

not-so-smart commented Aug 14, 2021

Current state of API coverage

Groups

Group Messages

Members

Chats

Chat Messages

Users

Likes

Calendar

Account

Polls

Attachments

Push

  • Implement push events

Miscellaneous and v4 stuff

  • Pending memberships
  • Relationships

Bots (ignored for now)

@not-so-smart not-so-smart added enhancement New feature or request help wanted Extra attention is needed good first issue Good for newcomers labels Aug 14, 2021
@not-so-smart not-so-smart pinned this issue Aug 31, 2021
@AlureonTheVirus
Copy link

not that I can speak for the project but I'd like to add that groupme has also added subgroups as what it calls "topics".

I assume that we will want to have websocket support at some point built in. A more Event-Driven approach would make bot development with this library a lot simpler and more straightforward/intuitive. (Let me know if I'm wrong and that's already implemented.)

It also seems that this project lacks a lot of in depth documentation and examples that other API wrappers typically have. (Not a diss, just an observation and possibly another goal to work towards.)

@not-so-smart
Copy link
Member Author

not that I can speak for the project but I'd like to add that groupme has also added subgroups as what it calls "topics".

Thank you! Yes, we do want to add support for topics, currently there is no framework for it but feel free to open a PR if you'd like to get that started :)

I assume that we will want to have websocket support at some point built in. A more Event-Driven approach would make bot development with this library a lot simpler and more straightforward/intuitive. (Let me know if I'm wrong and that's already implemented.)

Good news! The PR for websockets (#104) is currently open and will be merged soon! :D

It also seems that this project lacks a lot of in depth documentation and examples that other API wrappers typically have. (Not a diss, just an observation and possibly another goal to work towards.)

Yes, as you can see from this checklist, a lot of the framework (files, classes and method stubs to shape the relevant data structures) and even most of the implementation (filling in those method stubs with code that interacts with the API) is currently missing. API coverage is a slightly higher priority than documentation at this stage, but we do have docs at https://groupme.js.org/ which are automatically generated on each release and built from TS type information (for classes and their properties) along with any JSdoc comments present in the code (for descriptions of these objects and example usage). If you want to add to this documentation, just open a PR adding comments following the JSdoc standard (https://jsdoc.app/) and they'll be added to the generated docs in the next build.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

2 participants