Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hi, if the URL is like '127.0.0.1:8080/a/b', the result is '8080/a/b', which seems incorrect #149

Open
snails-za opened this issue Sep 7, 2021 · 2 comments

Comments

@snails-za
Copy link

No description provided.

@snails-za
Copy link
Author

from furl import furl
f = furl('127.0.0.1:8080/a/b')
f
furl('8080/a/b')

@gruns
Copy link
Owner

gruns commented Sep 10, 2021

great find!

this appears to be two issues.

issue #1: '127.0.0.1:8080/a/b'` is actually ambiguous: it could be parsed as

  • host 127.0.0.1, port 8080, and path /a/b

or as

  • path 127.0.0.1:8080/a/b (127.0.0.1:8080/a/b is a valid path)

in this ambiguity, furl defaults to the latter and parses 127.0.0.1:8080/a/b as a path. see #110

to force furl to parse 127.0.0.1:8080/a/b as an IP + port, include a scheme, eg

>>> f = furl('https://127.0.0.1:8080/a/b')
>>> f.url
'https://127.0.0.1:8080/a/b'

issue #2: that said, when furl parses '127.0.0.1:8080/a/b' as a path, i don't know why 127.0.0.1: is being dropped. that's strange

a bit more digging reveals it's the fact that the segment before the colon (which is a scheme separator, eg tel:555-555-5555) can't start with a number. eg:

>>> f = furl('t.t:8000/a/b')
>>> f.url
t.t:8000/a/b
>>> f = furl('1.1:8000/a/b')
>>> f.url
8000/a/b
>>> f = furl('t.5:8000/a/b')
>>> f.url
t.5:8000/a/b

this is likely an implementation detail of how https://docs.python.org/3/library/urllib.parse.html parses single colon schemes, like tel:, and drops single colon schemes that start with a digit

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants