Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extract non-default modules to external libraries #120

Open
grych opened this issue May 9, 2018 · 3 comments
Open

Extract non-default modules to external libraries #120

grych opened this issue May 9, 2018 · 3 comments
Assignees
Milestone

Comments

@grych
Copy link
Owner

grych commented May 9, 2018

  • Drab.Query
  • Drab.Modal

Plus: write a guide on how to extend Drab.

This must be done before 1.0, as it is a significant API change.

@grych grych mentioned this issue May 9, 2018
17 tasks
@grych
Copy link
Owner Author

grych commented May 11, 2018

Rename DrabModule behaviour to Drab.Plugin

@grych
Copy link
Owner Author

grych commented May 11, 2018

Extract all modules, including Drab.Live and Drab.Element, to the external libraries, but add them in the dependency, and as a default plugins.

New API:

  1. To include the plugin, add it to mix deps and to config as something like
config :drab, plugins: [Drab.Query, Drab.Live] ## Drab.Live and Drab.Element by default
  1. Plugins from config will be default to commander, when use Drab.Commander. You may still override it with use Drab.Commander, modules: [...] for the specific Commander

Note: why? It is because most of the Drab.Plugin modules (formerly DrabModule) are injecting some JS. This is for keeping page as small as it is possible

@grych grych self-assigned this May 13, 2018
@grych grych added this to the 1.0.0 milestone May 13, 2018
@grych grych modified the milestones: 1.0.0, 2.0.0 Jun 20, 2018
@grych
Copy link
Owner Author

grych commented Jun 20, 2018

Moved this to the future 2.0.0, as it is not so urgent.

@grych grych mentioned this issue Jun 20, 2018
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant