Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bug] ID returned when ingesting packages is incorrect #1414

Closed
jeffmendoza opened this issue Oct 17, 2023 · 2 comments
Closed

[bug] ID returned when ingesting packages is incorrect #1414

jeffmendoza opened this issue Oct 17, 2023 · 2 comments
Labels
bug Something isn't working

Comments

@jeffmendoza
Copy link
Collaborator

Describe the bug
When ingesting packages, the ID returned is the top-level ID (package type) and not the lowest level ID (package version)

https://github.com/guacsec/guac/blob/main/pkg/assembler/graphql/resolvers/package.resolvers.go#L19
https://github.com/guacsec/guac/blob/main/pkg/assembler/graphql/resolvers/package.resolvers.go#L28

To Reproduce

Ingest packages using GQL, note id returned

Expected behavior
Should be the lowest level ID (package version node id)

GUAC version
head

@jeffmendoza jeffmendoza added the bug Something isn't working label Oct 17, 2023
@jeffmendoza
Copy link
Collaborator Author

Note, whenever we change the backend interface to return ID and not extract it here in the resolver, this code will be obsoleted.

@pxp928
Copy link
Collaborator

pxp928 commented Oct 17, 2023

This was also caught in the PR by @knrc. This is changing to now return a flat struct of pkg IDs: #1367 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants