Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

3rd-party libs free version #3

Open
Meesayen opened this issue Nov 20, 2017 · 1 comment
Open

3rd-party libs free version #3

Meesayen opened this issue Nov 20, 2017 · 1 comment

Comments

@Meesayen
Copy link

Is there any plan for a 3rd-party libs free version of gumshoe? For example, using fetch instead of reqwest and have the client provide a polyfill for that, and similarly for .reduce, .trim and other things currently embedded in the dist files.

Reason for that is that as of today many of us are probably polyfilling browser features with the excellent polyfill.io service, or maybe we are already bundling some request libraries (reqwest, or got, or you name it) with webpack or some other means, therefore would be annoying to have an external dependency that unnecessarily send these resources again to the client.

@shellscape
Copy link
Contributor

No plans as yet. Gumshoe isn't intended to be bundled. It's a first-class script that needs to be added to the page independently of a bundle to ensure load priority. As such, it needs dependencies bundled to ensure they're available on demand.

I understand that Gilt is favoring polyfill.io at the moment, however, it'd be incredibly irresponsible for an independent lib to require or cater specifically to a service like that. That's not to say that bundling fetch and polyfills with the dist wouldn't be favorable versus reqwest, but there would have to be a compelling reason for that, like a size savings. As it stands, the minified file is fairly lean at 20kb, and a mere 3kb larger than ga.js with a lot more benefit.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants