Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Typo(?) in general_examples_algebra.py, example 23. #714

Closed
javimixet opened this issue Sep 25, 2024 · 1 comment
Closed

Typo(?) in general_examples_algebra.py, example 23. #714

javimixet opened this issue Sep 25, 2024 · 1 comment

Comments

@javimixet
Copy link

I had to change code in line 389 from sk23 = make_face(l1, l2) to sk23 = make_face(l1 + l2) for the revolve to work.

@jdegenstein
Copy link
Collaborator

Thanks for reporting! I added to my PR here #715, but I used a slightly different solution: sk23 = make_face([l1, l2]) which I think was probably what was originally intended.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants