Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace purrr::cross2() with tidyr::expand_grid() #24

Open
gvelasq opened this issue Apr 20, 2024 · 1 comment · May be fixed by #25
Open

Replace purrr::cross2() with tidyr::expand_grid() #24

gvelasq opened this issue Apr 20, 2024 · 1 comment · May be fixed by #25
Labels
help wanted ❤️ we'd love your help! upkeep maintenance, infrastructure, and similar

Comments

@gvelasq
Copy link
Owner

gvelasq commented Apr 20, 2024

Warning (test-tab.R:60:3): tab1() and tab2() work
`cross2()` was deprecated in purrr 1.0.0.
i Please use `tidyr::expand_grid()` instead.
i See <https://github.com/tidyverse/purrr/issues/768>.

Related: tidyverse/purrr#768

@gvelasq gvelasq changed the title Replace purrr::cross2() with tidyr::expand_grid() Replace purrr::cross2() with tidyr::expand_grid() Apr 20, 2024
@ramongss ramongss linked a pull request May 3, 2024 that will close this issue
@gvelasq gvelasq added upkeep maintenance, infrastructure, and similar help wanted ❤️ we'd love your help! labels May 21, 2024
@lhdjung
Copy link

lhdjung commented Aug 27, 2024

Hi, I saw that you currently use purrr::cross2() to create the tab_sequence object in tab2(). PR 26c090a replaces cross2() by tidyr::expand_grid(), but this new function currently returns its output in a different order than cross2().

If tab_sequence should retain its current order, there are a few options:

Also, the linked PR passes .filter = filter to tidyr::expand_grid(), but the function has no such parameter, so this won't work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted ❤️ we'd love your help! upkeep maintenance, infrastructure, and similar
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants