Skip to content
This repository has been archived by the owner on Dec 7, 2018. It is now read-only.

Get gwin_make_workflow to estimate the segment length #60

Open
Cyberface opened this issue Jul 19, 2018 · 3 comments
Open

Get gwin_make_workflow to estimate the segment length #60

Cyberface opened this issue Jul 19, 2018 · 3 comments

Comments

@Cyberface
Copy link
Contributor

No description provided.

@ahnitz
Copy link
Member

ahnitz commented Jul 20, 2018

@Cyberface I wasn't privy to this discussion, can you add a bit about about this? Is it just having a default? The reason one might change this is if one has a model that is sensitive to line behavior, then one needs to have better line whitening and a correspondingly longer filter.

@Cyberface
Copy link
Contributor Author

@ahnitz this is wrong sorry. I made the issue during the meeting so we wouldn't forget to do it but the title is misleading. It's not to do with the inverse truncation length so I'll change the title.

I think what this is supposed to mean is:

We should have a way for gwin_make_workflow to estimate the segment length for the analysis.
Which can be calculated from the prior information. i.e. what is the longest waveform in your prior.
Would we want to round this to the next power of 2?

I'm imagining this as an option that is by default computed by the code but you can override it by simply specifying it in the config file or override.

Does that make more sense?

@Cyberface Cyberface changed the title Get GWin to estimate the inverse-psd-length Get GWin to estimate the segment length Jul 20, 2018
@Cyberface Cyberface changed the title Get GWin to estimate the segment length Get gwin_make_workflow to estimate the segment length Jul 20, 2018
@ahnitz
Copy link
Member

ahnitz commented Jul 20, 2018

@Cyberface Ah, that's much clearer now, thanks!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants