Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

generateId produces very weak IDs. Needs to be replaced by something much more unique and safe #14

Open
TonyMasse opened this issue Dec 12, 2020 · 1 comment · May be fixed by #17
Open

generateId produces very weak IDs. Needs to be replaced by something much more unique and safe #14

TonyMasse opened this issue Dec 12, 2020 · 1 comment · May be fixed by #17

Comments

@TonyMasse
Copy link

I'm proposing to use UUID instead of simple small Integer, as this the current solution is very prone to collision.
@TonyMasse TonyMasse changed the title generateId produces very weak IDs. Need replaced by something much more unique and safe generateId produces very weak IDs. Needs to be replaced by something much more unique and safe Dec 12, 2020
TonyMasse added a commit to TonyMasse/vue-diagrams that referenced this issue Dec 12, 2020
@TonyMasse
feat(id): produce UUID with generateId
9bb9ab2 
This is the replace the much simpler but prone to problem simple (and small) random Integer generation.

Close gwenaelp#14
@TonyMasse
Copy link
Author

Moreover, having the same function defined in several files was making changes potentially difficult.
This function should be defined in one place, and imported from where it's needed.

This was referenced Dec 12, 2020
Closed
Merged
TonyMasse added a commit to TonyMasse/vue-diagrams that referenced this issue Dec 13, 2020
@TonyMasse
feat(id): produce UUID with generateId. move to /utils/Identifier.js
bebc5e4 
This is the replace the much simpler but prone to problem simple (and small) random Integer generation.
And moved the function to its own `/utils/Identifier.js` file for ease of maintenance.

Close gwenaelp#14
This was referenced Dec 13, 2020
Closed
Merged
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
1 participant
@TonyMasse