Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mira raises KeyError: 'value' when parsing BIOMD0000000949 #197

Closed
djinnome opened this issue Jul 11, 2023 · 2 comments · Fixed by #199
Closed

Mira raises KeyError: 'value' when parsing BIOMD0000000949 #197

djinnome opened this issue Jul 11, 2023 · 2 comments · Fixed by #199

Comments

@djinnome
Copy link
Contributor

I decided to go through all the Biomodels AMRs and see if I could load them, and got this mira error:

../../mira/mira/sources/askenet/petrinet.py:106: in template_model_from_askenet_json
 
    param_values = {
>       p['id']: p['value'] for p in ode_semantics.get('parameters', [])
    }
E   KeyError: 'value'

../../mira/mira/sources/askenet/petrinet.py:107: KeyError

The problem appears to be that the AMR does not have a value for the baseline_dummy_variable parameter:

https://github.com/DARPA-ASKEM/experiments/blob/953808422c72dd0ab91dc7114ff3e581dfef0dac/thin-thread-examples/mira_v2/biomodels/BIOMD0000000949/model_askenet.json#L339-L346

Even though the underlying SBML model does contain a value for the parameter

https://github.com/DARPA-ASKEM/experiments/blob/953808422c72dd0ab91dc7114ff3e581dfef0dac/thin-thread-examples/mira_v2/biomodels/BIOMD0000000949/src/main/Chitnis2008.xml#L853

@djinnome
Copy link
Contributor Author

djinnome commented Jul 11, 2023

Other Biomodels that display the same phenotype are:

  • BIOMD0000000956
  • BIOMD0000000960
  • BIOMD0000000982
  • BIOMD0000000962
  • BIOMD0000000969
  • BIOMD0000000977
  • BIOMD0000000983
  • BIOMD0000000991
  • BIOMD0000000963
  • BIOMD0000000978
  • MODEL1805220001
  • MODEL2111170001

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants