Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

scenario 1a contains a k parameter in the rate law that is not in the parameters section of the AMR #200

Closed
djinnome opened this issue Jul 12, 2023 · 2 comments

Comments

@djinnome
Copy link
Contributor

The symbol k is referenced here:
Equation (9) on page 4 of:

Tay, B. K., Roby, C. A., Wu, J. W., & Tan, D. Y. (2021). Dynamical analysis of universal masking on the pandemic. International Journal of Environmental Research and Public Health, 18(17). https://doi.org/10.3390/ijerph18179027

https://github.com/indralab/mira/blob/56bf4c0d77919142684c8cbfb3521b7bf4470888/notebooks/hackathon_2023.07/scenario1_a.json#L129

But is not in here:

https://github.com/indralab/mira/blob/56bf4c0d77919142684c8cbfb3521b7bf4470888/notebooks/hackathon_2023.07/scenario1_a.json#L175-L232

@bgyori
Copy link
Member

bgyori commented Jul 12, 2023

@djinnome I think this is an issue with the version of the model you're looking at. I believe Sam pinned your model import temporarily to an old version which shouldn't be necessary anymore.

@bgyori
Copy link
Member

bgyori commented Jul 12, 2023

These are confirmed to be okay on the latest hackathon branch (whose current state has also been merged into main).

@bgyori bgyori closed this as completed Jul 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants