Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Scenario 1c model missing a '1/N' term in the rate law expression #203

Closed
VigneshSella opened this issue Jul 12, 2023 · 4 comments
Closed

Scenario 1c model missing a '1/N' term in the rate law expression #203

VigneshSella opened this issue Jul 12, 2023 · 4 comments

Comments

@VigneshSella
Copy link

In Scenario1c model at line 139 there is no '1/N' term, I believe this yields incorrect units in the expression and such leads to failed calculations in subsequent calculations.
@VigneshSella
Copy link
Author

The '1/N' term is present in Scenario 1a model

@djinnome
Copy link
Contributor

confirmed this issue remains in the latest hackathon branch.

@bgyori
Copy link
Member

bgyori commented Jul 12, 2023

Sorry, I just made a mistake when typing in the rate equation. I'll fix that soon.

@bgyori
Copy link
Member

bgyori commented Jul 12, 2023

This is fixed on the hackathon branch.

@bgyori bgyori closed this as completed Jul 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@djinnome @bgyori @VigneshSella