Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Scenario 2b - Syntax error in the AMR #213

Closed
VigneshSella opened this issue Jul 14, 2023 · 4 comments
Closed

Scenario 2b - Syntax error in the AMR #213

VigneshSella opened this issue Jul 14, 2023 · 4 comments

Comments

@VigneshSella
Copy link

VigneshSella commented Jul 14, 2023 •
edited
Loading

In the AMR there is a syntax error in the rate expression "t1" (and I believe most of the expressions):

{"ode": {"rates": [{"target": "t1", "expression": "I_cido:0000371*V1_vo:0004987*ai*beta_0*beta_scale"

The terms "I_cido:0000371 and V1_vo:0004987 are syntax errors and includes the ID I believe.
@VigneshSella
Copy link
Author

I think this should help as well:
https://github.com/indralab/mira/blob/5f22de7587de3ee8a484a60c3284448e5155e9fb/mira/metamodel/utils.py#L7

@bgyori
Copy link
Member

bgyori commented Jul 14, 2023

I see, I didn't realize that these couldn't be parsed after being generated. I'll try to come up with a workaround and regenerate the models.

@bgyori
Copy link
Member

bgyori commented Jul 14, 2023

Should be fixed in 40d0f4a

@VigneshSella
Copy link
Author

Fixed ^

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@bgyori @VigneshSella